[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20070513181225.GV4629@kernel.dk>
Date: Sun, 13 May 2007 20:12:27 +0200
From: Jens Axboe <jens.axboe@...cle.com>
To: Dmitry Torokhov <dtor@...ightbb.com>
Cc: "Yin,Fengwei" <yfw.kernel@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: Is this a preempt issue in drivers/input/evdev.c
On Sat, May 12 2007, Dmitry Torokhov wrote:
> Hi,
>
> On Friday 11 May 2007 23:18, Yin,Fengwei wrote:
> >
> > So if the evdev_release() is preempted at the point marked by another
> > process which will open the evdev, which will make operation sequence
> > like:
> >
> > --evdev->open in evdev_release()
> > -----> preempted
> > evdev->open++ and input_open_devie()
> > <----- reschedule
> > input_close_device()
> >
> > Should we introduce a mutex here? Or do I miss something? Thanks.
> >
>
> Locking is completely absent in evdev. There was a patch introducing
> locking in recent -mm's but it got dropped. I need to refresh it.
How did stuff like that ever get merged, btw? I still have a completely
trivially oopsable rmmod psmouse problem, I hope it'll get fixed for
2.6.22.
--
Jens Axboe
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists