linux-kernel - Re: [PATCH] "volatile considered harmful", take 3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46456DDE.5070006@gmail.com>
Date:	Sat, 12 May 2007 13:03:50 +0530
From:	jimmy bahuleyan <knight.camelot@...il.com>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
CC:	Satyam Sharma <satyam.sharma@...il.com>,
	"H. Peter Anvin" <hpa@...or.com>, Jonathan Corbet <corbet@....net>,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	Johannes Stezenbach <js@...uxtv.org>,
	Jesper Juhl <jesper.juhl@...il.com>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Heikki Orsila <shdl@...alwe.fi>
Subject: Re: [PATCH] "volatile considered harmful", take 3

Stefan Richter wrote:
> Satyam Sharma wrote:
>> Coming back to the document, we do need to document / find
>> consensus on the "preferred" way to do similar business in the
>> kernel, and my opinion as far as that is concerned is to shun
>> volatile wherever possible (which includes the case originally
>> discussed above).
> 
> I too recommend that volatile-considered-harmful.txt is not watered down
> by an ever growing "but if" list.  If anybody knows what he does, he
> still can program in a deviating way --- provided that he leaves a brief
> comment in the code, telling why it is possible and beneficial to use
> the volatile qualifier in this special case.

yes, this seems the better option. generally, the more complex rules you
have, the more people tend to break it (either through not being able t
comprehend it or cos it's too difficult to follow).

i believe, the doc here is pretty unambiguous regarding the fact that
volatile should be avoided. And as Stefan pointed out, anyone who feels
the need to use, must surely _know_ what he is doing & hence is in a
position t make that decision (followed ofcourse with a doc of why it
was done).

it would be better we didn't grow the list of exceptions - IMHO.

-jb
-- 
Tact is the art of making a point without making an enemy.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/