linux-kernel - [PATCH] driver core: fix warning of temporarily unused multithreaded probing function (was: Re: Linux 2.6.22-rc1)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070513094752.GA5232@gollum.tnic>
Date:	Sun, 13 May 2007 11:47:53 +0200
From:	Borislav Petkov <bbpetkov@...oo.de>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Greg KH <gregkh@...e.de>,
	Cornelia Huck <cornelia.huck@...ibm.com>
Subject: [PATCH] driver core: fix warning of temporarily unused multithreaded probing function (was: Re: Linux 2.6.22-rc1)

Hi,

if I'm not mistaken, despite the PCI_MULTITHREAD_PROBE removal,
Cornelia Huck wanted to keep driver-core-per-subsystem-multithreaded-probing.patch:

<quote>
> Wouldn't per-subsystem multithreaded probing just expose bugs that
> could also be exposed on SMP systems?

Yes, it would be the same.
</quote>

However, device_probe_drivers() remains temporarily unused, so we either
suppress the compiler warning or remove the whole function altogether. The
following patch does the first.

-----
From: Borislav Petkov <bbpetkov@...oo.de>

This patch shuts the following warning:

drivers/base/dd.c:211: warning: 'device_probe_drivers' defined but not used

Signed-off-by: Borislav Petkov <bbpetkov@...oo.de>

--

Index: 22-rc1/drivers/base/dd.c
===================================================================
--- 22-rc1/drivers/base/dd.c.orig
+++ 22-rc1/drivers/base/dd.c
@@ -207,7 +207,7 @@ static int __device_attach(struct device
 	return driver_probe_device(drv, dev);
 }

-static int device_probe_drivers(void *data)
+static int __used device_probe_drivers(void *data)
 {
 	struct device *dev = data;
 	int ret = 0;


-- 
Regards/Gruß,
    Boris.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/