linux-kernel - Re: Kconfig warnings on latest GIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1179147311.2647.47.camel@johannes.berg>
Date:	Mon, 14 May 2007 14:55:11 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Simon Horman <horms@...ge.net.au>
Cc:	Timur Tabi <timur@...escale.com>,
	Kim Phillips <kim.phillips@...escale.com>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	Ismail Dönmez <ismail@...dus.org.tr>,
	Kumar Gala <galak@...nel.crashing.org>,
	Michael Schmitz <schmitz@...ian.org>,
	Roman Zippel <zippel@...ux-m68k.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>,
	Ralf Baechle <ralf@...ux-mips.org>
Subject: Re: Kconfig warnings on latest GIT

Simon,

> I don't think that this is quite right, or at least it isn't quite the
> same as before.

Yeah, I think you're right.

>  I think that was is below will toggle
> SYS_SUPPORTS_APM_EMULATION when PMAC_APM_EMU is selected,
> which I think is what you want. Is it also neccessary to
> add a dependancy on PPC_PMAC to PMAC_APM_EMU ?

No, it depends on ADB_PMU which depends on PPC_PMAC.

> config PMAC_APM_EMU
> 	tristate "APM emulation"
> 	select APM_EMULATION
> 	depends on ADB_PMU && PM
> 
> config SYS_SUPPORTS_APM_EMULATION
> 	bool
> 	default y if PMAC_APM_EMU

I still have to try it, I haven't been yet seen Kumar's fix that he said
he'd done.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (191 bytes)