linux-kernel - Re: Kconfig warnings on latest GIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0705140923470.24559@gate.crashing.org>
Date:	Mon, 14 May 2007 09:24:43 -0500 (CDT)
From:	Kumar Gala <galak@...nel.crashing.org>
To:	Johannes Berg <johannes@...solutions.net>
cc:	Simon Horman <horms@...ge.net.au>,
	Timur Tabi <timur@...escale.com>,
	Kim Phillips <kim.phillips@...escale.com>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	Ismail Dönmez <ismail@...dus.org.tr>,
	Michael Schmitz <schmitz@...ian.org>,
	Roman Zippel <zippel@...ux-m68k.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>,
	Ralf Baechle <ralf@...ux-mips.org>
Subject: Re: Kconfig warnings on latest GIT

On Mon, 14 May 2007, Johannes Berg wrote:

> Simon,
>
> > I don't think that this is quite right, or at least it isn't quite the
> > same as before.
>
> Yeah, I think you're right.
>
> >  I think that was is below will toggle
> > SYS_SUPPORTS_APM_EMULATION when PMAC_APM_EMU is selected,
> > which I think is what you want. Is it also neccessary to
> > add a dependancy on PPC_PMAC to PMAC_APM_EMU ?
>
> No, it depends on ADB_PMU which depends on PPC_PMAC.
>
> > config PMAC_APM_EMU
> > 	tristate "APM emulation"
> > 	select APM_EMULATION
> > 	depends on ADB_PMU && PM
> >
> > config SYS_SUPPORTS_APM_EMULATION
> > 	bool
> > 	default y if PMAC_APM_EMU
>
> I still have to try it, I haven't been yet seen Kumar's fix that he said
> he'd done.
>
> johannes

this was my fix which looks pretty much the same.

- k

diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index ccc5410..af70799 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -118,6 +118,7 @@ config GENERIC_BUG
 	depends on BUG

 config SYS_SUPPORTS_APM_EMULATION
+	default y if PMAC_APM_EMU
 	bool

 config DEFAULT_UIMAGE
diff --git a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig
index 58926da..f44c94a 100644
--- a/drivers/macintosh/Kconfig
+++ b/drivers/macintosh/Kconfig
@@ -113,7 +113,6 @@ config PMAC_SMU

 config PMAC_APM_EMU
 	tristate "APM emulation"
-	select SYS_SUPPORTS_APM_EMULATION
 	select APM_EMULATION
 	depends on ADB_PMU && PM

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/