[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070515195006.GA5669@martell.zuzino.mipt.ru>
Date: Tue, 15 May 2007 23:50:06 +0400
From: Alexey Dobriyan <adobriyan@...il.com>
To: Al Viro <viro@....linux.org.uk>
Cc: torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
mchehab@...radead.org
Subject: Re: [PATCH] em28xx and ivtv should depend on PCI
On Tue, May 15, 2007 at 08:36:40PM +0100, Al Viro wrote:
> --- a/drivers/media/video/ivtv/Kconfig
> +++ b/drivers/media/video/ivtv/Kconfig
> @@ -1,6 +1,6 @@
> config VIDEO_IVTV
> tristate "Conexant cx23416/cx23415 MPEG encoder/decoder support"
> - depends on VIDEO_V4L1 && VIDEO_V4L2 && USB && I2C && EXPERIMENTAL
> + depends on VIDEO_V4L1 && VIDEO_V4L2 && USB && I2C && EXPERIMENTAL && PCI
> select FW_LOADER
> select VIDEO_TUNER
> select VIDEO_TVEEPROM
Don't forget to remove #error:
Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>
--- a/drivers/media/video/ivtv/ivtv-driver.h
+++ b/drivers/media/video/ivtv/ivtv-driver.h
@@ -71,10 +71,6 @@ #ifdef CONFIG_LIRC_I2C
# error "This driver is not compatible with the LIRC I2C kernel configuration option."
#endif /* CONFIG_LIRC_I2C */
-#ifndef CONFIG_PCI
-# error "This driver requires kernel PCI support."
-#endif /* CONFIG_PCI */
-
#define IVTV_ENCODER_OFFSET 0x00000000
#define IVTV_ENCODER_SIZE 0x00800000 /* Last half isn't needed 0x01000000 */
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists