linux-kernel - Re: [PATCH] ubi: kill homegrown endian macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1179413443.3642.49.camel@sauron>
Date:	Thu, 17 May 2007 17:50:43 +0300
From:	Artem Bityutskiy <dedekind@...radead.org>
To:	Christoph Hellwig <hch@....de>
Cc:	akpm@...l.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ubi: kill homegrown endian macros

Christoph,

On Thu, 2007-05-17 at 16:32 +0200, Christoph Hellwig wrote:
> Kill ubis homegrown endianess handling crap and replace it with
> the normal kernel endianess handling.

Err,__be32 and the company are just sparse things, while I have compiler
checks with my struct ubi32_t and friends. JFFS2 also uses the same
technique. Why do you force me to rely on sparse instead instead of
compiler?

Well, I see the good side of your change - no home-brewed media<->cpu
things. Fair enough and nice. But why don't you make __be32 a struct
(just like I do) so that compiler could complain then?

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/