linux-kernel - Re: Asynchronous scsi scanning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070517172023.GL10562@parisc-linux.org>
Date:	Thu, 17 May 2007 11:20:23 -0600
From:	Matthew Wilcox <matthew@....cx>
To:	Satyam Sharma <satyam.sharma@...il.com>
Cc:	Simon Arlott <simon@...e.lp0.eu>,
	James Bottomley <james.bottomley@...eleye.com>,
	Dave Jones <davej@...hat.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-scsi@...r.kernel.org, kernel-packagers@...r.kernel.org,
	"Robert P. J. Day" <rpjday@...dspring.com>
Subject: Re: Asynchronous scsi scanning

On Thu, May 17, 2007 at 10:43:06PM +0530, Satyam Sharma wrote:
> >No, it does matter.  Your suggestion doesn't work, because
> >/sys/module/scsi_mod/parameters/ belongs to the module code.  To create
> >a new attribute there, you use the module_param() code -- and there's
> >no way to have code called when your parameter is changed.

(thanks, Roland for pointing out that I'm incorrect about code being
called)

> Ok, thanks for pointing out that /sys/module/scsi_mod/parameters/wait...
> is _wrong_. Could you suggest something that would be _right_?

No, I can't, which is why I find it hard to like the idea of "use
sysfs".  I have no particular love for using a module like this, but
my preferred way (a new verb for /proc/scsi/scsi) isn't liked by others.
So here we stand.

> You're almost right here. But IMHO this is simply a case of
> doing something in some kernel subsystem in a proper/better
> way than it is being done presently.
> 
> Anyway, like I said on another thread, discussions here tend to be
> most productive only over code, so I'll try and make a patch to do
> this some other way.

Come up with a sensible suggestion, and I'll listen to you.  Code isn't
the issue.  API is the issue.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/