linux-kernel - Re: [PATCH] ALPHA: MARVEL - check for allocated memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070517103113.107f4363.akpm@linux-foundation.org>
Date:	Thu, 17 May 2007 10:31:13 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Cyrill Gorcunov <gorcunov@...il.com>
Cc:	Richard Henderson <rth@...ddle.net>,
	linux-kernel-list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALPHA: MARVEL - check for allocated memory

On Thu, 17 May 2007 18:37:12 +0400 Cyrill Gorcunov <gorcunov@...il.com> wrote:

> [Andrew Morton - Wed, May 16, 2007 at 11:44:55AM -0700]
> | On Wed, 16 May 2007 22:12:14 +0400
> | Cyrill Gorcunov <gorcunov@...il.com> wrote:
> | 
> | > This patch adds checking for allocated memory
> | > which is used to hold AGP info. Also some whitespace
> | > cleanup.
> | 
> | The inclusion of all the whitespace fixies makes it rather hard to
> | see what the patch actually does.
> | 
> | I'm not sure that I can be bothered with this, really.  afaict the
> | checks you're adding are for boot-time allocations which we tend
> | to assume won't fail, and they're kmalloc(small-amount, GFP_KERNEL)
> | which is basically infallible, and it only affects, err, alpha.
> | 
> 
> So you think we could leave all as is? I mean sould I just drop the patch?

mutter.  I spose we should fix those sites which can be called at times other than
system boot.  Often one can use the lack of __init annotation to work out if a site
is being called after boot.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/