linux-kernel - Re: [PATCH] Fix/add raw1394 CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200705201703.37561.arnd@arndb.de>
Date:	Sun, 20 May 2007 17:03:36 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
Cc:	Petr Vandrovec <petr@...drovec.name>, dan@...nedy.org,
	linux1394-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix/add raw1394 CONFIG_COMPAT code

On Sunday 20 May 2007, Stefan Richter wrote:
> 
> > Note that this data structure only needs conversion on x86_64 and ia64, but
> > not on powerpc and other 64 bit architectures that align __u64 also in
> > 32 bit mode.
> 
> Is this conversion just unnecessary or actually harmful on ppc64 and others?

With the current patch, the compat_ioctl function does not handle the ppc32
version of the structure at all, so it's broken there, it would at least
need a 

	case RAW1394_IOC_GET_CYCLE_TIMER:
		err = raw1394_ioctl(NULL, file, cmd, arg);
		break;

	Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/