linux-kernel - Re: [PATCH (v2)] crypto: Remove pointless padlock module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <464FF099.1000107@simon.arlott.org.uk>
Date:	Sun, 20 May 2007 07:54:17 +0100
From:	Simon Arlott <simon@...e.lp0.eu>
To:	Herbert Xu <herbert@...dor.apana.org.au>
CC:	Randy Dunlap <randy.dunlap@...cle.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	michal@...ix.cz, ioe-lkml@...eria.de
Subject: Re: [PATCH (v2)] crypto: Remove pointless padlock module

On 20/05/07 04:15, Herbert Xu wrote:
> On Sat, May 19, 2007 at 08:28:17PM +0100, Simon Arlott wrote:
>> It should be a bool that doesn't select anything, the AES and SHA modules 
>> will select CRYPTO_ALGAPI. It could also depend on MVIAC3_2 || MVIA_C7 
>> instead of X86_32.
> 
> Having it as a tristate means that we don't have to duplicate the
> dependencies and selects that each padlock algorithm would otherwise
> do.  So is there actually a problem with it being a tristate?

It has nothing to compile as a module, so M makes no sense. Each algorithm 
already selects CRYPTO_ALGAPI indirectly.

-- 
Simon Arlott
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/