linux-kernel - Re: [patch 43/69] i386: HPET, check if the counter works

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070521145719.739bb8eb.akpm@linux-foundation.org>
Date:	Mon, 21 May 2007 14:57:19 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Chris Wright <chrisw@...s-sol.org>, linux-kernel@...r.kernel.org,
	stable@...nel.org, Andi Kleen <ak@...e.de>,
	Justin Forbes <jmforbes@...uxtx.org>,
	Zwane Mwaikambo <zwane@....linux.org.uk>,
	"Theodore Ts'o" <tytso@....edu>,
	Randy Dunlap <rdunlap@...otime.net>,
	Dave Jones <davej@...hat.com>,
	Chuck Wolber <chuckw@...ntumlinux.com>,
	Chris Wedgwood <reviews@...cw.f00f.org>,
	Michael Krufky <mkrufky@...uxtv.org>,
	Chuck Ebbert <cebbert@...hat.com>,
	torvalds@...ux-foundation.org, alan@...rguk.ukuu.org.uk,
	guilherme@...tralinf.com.br, johnstul@...ibm.com
Subject: Re: [patch 43/69] i386: HPET, check if the counter works

On Mon, 21 May 2007 21:58:55 +0200
Thomas Gleixner <tglx@...utronix.de> wrote:

> The warning in the NOHZ code, which triggers when a CPU goes idle with
> softirqs pending can fill up the logs quite quickly. Rate limit the
> output until we found the root cause of that problem.
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> 
> Index: linux-2.6.21/kernel/time/tick-sched.c
> ===================================================================
> --- linux-2.6.21.orig/kernel/time/tick-sched.c
> +++ linux-2.6.21/kernel/time/tick-sched.c
> @@ -167,9 +167,15 @@ void tick_nohz_stop_sched_tick(void)
>  		goto end;
>  
>  	cpu = smp_processor_id();
> -	if (unlikely(local_softirq_pending()))
> -		printk(KERN_ERR "NOHZ: local_softirq_pending %02x\n",
> -		       local_softirq_pending());
> +	if (unlikely(local_softirq_pending())) {
> +		static int ratelimit;
> +
> +		if (ratelimit < 10) {
> +			printk(KERN_ERR "NOHZ: local_softirq_pending %02x\n",
> +			       local_softirq_pending());
> +			ratelimit++;
> +		}
> +	}

that's not a "rate" limit.  I resist the temptation to rename it to "limit"
to keep mainline and -stable in sync, and coz it's temporary (we hope).
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/