linux-kernel - Re: [PATCH]: UDF code style conversion to kernel style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070524115735.a1a2e32e.randy.dunlap@oracle.com>
Date:	Thu, 24 May 2007 11:57:35 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	"Pekka Enberg" <penberg@...helsinki.fi>
Cc:	"Cyrill Gorcunov" <gorcunov@...il.com>, "Jan Kara" <jack@...e.cz>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Christoph Hellwig" <hch@...radead.org>,
	"Ben Fennema" <bfennema@...con.csc.calpoly.edu>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH]: UDF code style conversion to kernel style

On Thu, 24 May 2007 21:47:42 +0300 Pekka Enberg wrote:

> Hi Cyrill,
> 
> On 5/23/07, Cyrill Gorcunov <gorcunov@...il.com> wrote:
> > @@ -2103,7 +1944,7 @@ long udf_block_map(struct inode *inode, sector_t block)
> >  	kernel_lb_addr eloc;
> >  	uint32_t elen;
> >  	sector_t offset;
> > -	struct extent_position epos = { NULL, 0, { 0, 0}};
> > +	struct extent_position epos = {};
> 
> Bits like these in the middle of indentation fixes makes me feel
> uneasy. Could we simply ask Andrew to run Lindent on the UDF sources
> at some convinient point and push those to Linus like we did with
> mm/slab.c if I recall correctly? Its safer to do cleanups like these
> after that.

but Lindent needs some hand-holding / eyeball help as well...

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/