linux-kernel - Re: [PATCH] old declaration ritchie style fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4656A0F0.4050909@s5r6.in-berlin.de>
Date:	Fri, 25 May 2007 10:40:16 +0200
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Jiri Slaby <jirislaby@...il.com>
CC:	Yoann Padioleau <padator@...adoo.fr>,
	kernel-janitors@...ts.osdl.org, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] old declaration ritchie style fix

Jiri Slaby wrote:
> Yoann Padioleau napsal(a):
>>  static int
>> -receivepkt (target, buffer)
>> -	int target;
>> -	unsigned char *buffer;
>> +receivepkt (int target, unsigned char *buffer)
> 
> When you are at it, you can also get rid of bsd return-type-on-its-own-line
> style

return-type-on-its-own-line is IMO OK if it occurs consistently in a
file.  It can improve readability particularly if long return types are
combined with long function names.

> + remove the space before parenthesis.

Indeed.
-- 
Stefan Richter
-=====-=-=== -=-= ==--=
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/