| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 25 May 2007 10:41:09 +0200 From: Andi Kleen <andi@...stfloor.org> To: Ingo Molnar <mingo@...e.hu> Cc: Andi Kleen <andi@...stfloor.org>, Satyam Sharma <satyam.sharma@...il.com>, Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org, Peter Zijlstra <a.p.zijlstra@...llo.nl> Subject: Re: [patch] x86_64: fix sched_clock() On Fri, May 25, 2007 at 10:34:31AM +0200, Ingo Molnar wrote: > > * Andi Kleen <andi@...stfloor.org> wrote: > > > > > Hmm indeed. I actually had it correct at some point (i remember > > > > fixing 64bit compile errors in sched-clock ;-). I guess the > > > > Makefile hunk accidentially dropped out during some later merging > > > > and this didn't get noticed due to the weak attribute. > > > > > > well the tsc.h bit was needed too. > > > > It's not in defconfig at least. I just tried it. > > what do you mean? The tsc.h bit is needed because Means i readded the Makefile hunk and it compiled for me in 64bit without changing anything else. > arch/i386/kernel/sched-clock.c (now built on x86_64 too with the patch i > sent) uses the tsc_disable global flag which is non-existent on x86_64. > So my tsc.h change adds that global flag, always-defined to 0. My version of sched_clock.c doesn't have any reference to tsc_disable. -andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists