linux-kernel - Re: [patch] sched_clock(): cleanups, #2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070525121540.GA24083@one.firstfloor.org>
Date:	Fri, 25 May 2007 14:15:40 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Andi Kleen <andi@...stfloor.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Satyam Sharma <satyam.sharma@...il.com>,
	linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [patch] sched_clock(): cleanups, #2

On Fri, May 25, 2007 at 02:02:28PM +0200, Ingo Molnar wrote:
> 
> * Andi Kleen <andi@...stfloor.org> wrote:
> 
> > > find below the cleanups from my first patch that didnt make it into 
> > > your cleanups. (plus one more cleanup i noticed while merging the 
> > > missing bits from my first patch) Goes after the bugfix i just sent. 
> > > Please apply.
> > 
> > I cannot apply it as is because it changes code from the paravirtops 
> > patch too.
> 
> ok - then please merge that single hunk into the paravirtops patch - and 
> leave the other 6 hunks in this patch.

I added the empty lines too.

> 
> > BTW to nitpick the original formattings you changed are all probably 
> > standard code style and the new comment is a classical i++; /* 
> > Increase i */
> 
> could you please quote the portion from my patch that you are talking 
> about?

-static int sc_freq_event(struct notifier_block *nb, unsigned long event,
-                        void *data)
+static int
+sc_freq_event(struct notifier_block *nb, unsigned long event, void *data)

and

+               /*
+                * Still no frequency? Then fall back to tsc_khz:  
+                */
                if (!freq->new)
                        freq->new = tsc_khz;


-Andi (who hopes this thread will end soon now and we can all go
back to more important issues)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/