linux-kernel - Re: [RFC] LZO de/compression support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 25 May 2007 18:27:21 +0530
From:	"Nitin Gupta" <nitingupta910@...il.com>
To:	"Richard Purdie" <richard@...nedhand.com>
Cc:	linux-kernel@...r.kernel.org, linux-mm-cc@...top.org,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Satyam Sharma" <satyam.sharma@...il.com>,
	"Andrey Panin" <pazke@...pac.ru>, "Bret Towe" <magnade@...il.com>,
	"Michael-Luke Jones" <mlj28@....ac.uk>
Subject: Re: [RFC] LZO de/compression support - take 4

Hi Richard,

On 5/25/07, Richard Purdie <richard@...nedhand.com> wrote:
> On Fri, 2007-05-25 at 17:15 +0530, Nitin Gupta wrote:
> > Richard, can you please provide perf. results for this patch also?
> > Also, can you please mail back latest version of your LZO patch? In
> > meantime, I will try to include benchmarking support to the
> > 'compress-test' module.
>
> This version is 15% slower at decompression and about equal on
> compression.
>

If you don't mind, can you please try patch attached now? I have now
also rolled back that cpu_to_le16() change as Satyam suggested. I see
no other reason for this perf. loss as I made no other change!

Also, can you please verify if you are comparing your _safe_ version
with this patch? This patch does not include unsafe version and the
safe one is simply called lzo1x_decompress().

> I am however still strongly of the opinion that we should just use the
> version in -mm (which is my latest version).
>

I love this cleaned-up patch just sooo much! :)
Anyhow, if we can spend just small time scanning through these ~500
LOC to find reasons for any perf. loss, we will gain a lot!

Thanks,
Nitin

Download attachment "patch_lzo_2.6.22-rc2_richard_test.bz2" of type "application/x-bzip2" (4727 bytes)