linux-kernel - Re: 2.6.22-rc2-mm1: NetworkManager fails to find ipw2200 again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1180136450.4226.45.camel@lov.localdomain>
Date:	Sat, 26 May 2007 01:40:50 +0200
From:	Kay Sievers <kay.sievers@...y.org>
To:	Greg KH <gregkh@...e.de>
Cc:	Matt Mackall <mpm@...enic.com>, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, yi.zhu@...el.com,
	Cornelia Huck <cornelia.huck@...ibm.com>
Subject: Re: 2.6.22-rc2-mm1: NetworkManager fails to find ipw2200 again

On Fri, 2007-05-25 at 16:12 -0700, Greg KH wrote:
> On Fri, May 25, 2007 at 06:01:09PM -0500, Matt Mackall wrote:
> > Bisect sequence went 56+ 84+ 98+ 105- 102- 100+ 101+. Looks like 102's
> > to blame:
> > 
> > driver-core-check-return-code-of-sysfs_create_link.patch 
> > 
> > From: Cornelia Huck <cornelia.huck@...ibm.com>
> > 
> > Check for return value of sysfs_create_link() in device_add() and
> > device_rename().  Add helper functions device_add_class_symlinks() and
> > device_remove_class_symlinks() to make the code easier to read.
> 
> {sigh}
> 
> This wouldn't be the first time this patch has broken things :(
> 
> Andrew, can you drop this from your tree?
> 
> Cornelia, can you rework this to not break things?

Before we continue that road, we should define the expected behavior for
the "cleanup" in error paths. Implementing that transaction-like model,
to rewind a the complete device-creation when something like a symlink
can't be created, may not always be the right thing to do.

I think in most cases, we just want to write something like that to the
error logs and continue, instead of letting a whole subsystem fail, or
in the worst case, prevent the box from booting up.

Thanks,
Kay

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/