linux-kernel - Re: 2.6.22-rc2-mm1: NetworkManager fails to find ipw2200 again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070525170209.40ad51d5.akpm@linux-foundation.org>
Date:	Fri, 25 May 2007 17:02:09 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Greg KH <gregkh@...e.de>
Cc:	Matt Mackall <mpm@...enic.com>, Kay Sievers <kay.sievers@...y.org>,
	linux-kernel@...r.kernel.org, yi.zhu@...el.com,
	Cornelia Huck <cornelia.huck@...ibm.com>
Subject: Re: 2.6.22-rc2-mm1: NetworkManager fails to find ipw2200 again

On Fri, 25 May 2007 16:12:57 -0700 Greg KH <gregkh@...e.de> wrote:

> On Fri, May 25, 2007 at 06:01:09PM -0500, Matt Mackall wrote:
> > Bisect sequence went 56+ 84+ 98+ 105- 102- 100+ 101+. Looks like 102's
> > to blame:
> > 
> > driver-core-check-return-code-of-sysfs_create_link.patch 
> > 
> > From: Cornelia Huck <cornelia.huck@...ibm.com>
> > 
> > Check for return value of sysfs_create_link() in device_add() and
> > device_rename().  Add helper functions device_add_class_symlinks() and
> > device_remove_class_symlinks() to make the code easier to read.
> 
> {sigh}
> 
> This wouldn't be the first time this patch has broken things :(

Why does checking these errors cause ipw2200 to fail?

> Andrew, can you drop this from your tree?

Would prefer that we debug things first.  It could be that ipw2200 is
trying to create symlinks which already exist.  This might indicate a
programming error in ipw2200, which is what the patch is *for*.  If it
is indeed an ipw2200 bug then the lesson is that we should have been checking
for errors on day one - that way, we'd never have shipped a buggy ipw2200 driver.

I have an ipw2200 - I'll see if I can reproduce this and I'll add some
debugging code in there.  Probably that debugging code should become
permanent.

> Cornelia, can you rework this to not break things?

Things might be already broken?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/