linux-kernel - Re: [PATCH 1/7] cxgb3 - Fix SGE page management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <465B58DE.1010308@garzik.org>
Date:	Mon, 28 May 2007 18:34:06 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	divy@...lsio.com
CC:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	swise@...ngridcomputing.com
Subject: Re: [PATCH 1/7] cxgb3 - Fix SGE page management

divy@...lsio.com wrote:
> From: Divy Le Ray <divy@...lsio.com>
> 
> Streamline page management on RX.
> Fix dma mappings.
> 
> Signed-off-by: Divy Le Ray <divy@...lsio.com>

NAK #1:  "streamline" is not a bug-fixes-only change, which is the only 
type of change appropriate for 2.6.22-rc.

NAK #2:  You should use the page_address(page) accessor rather than 
creating a struct member in the same struct as your page, solely to 
contain the virtual address.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/