linux-kernel - Re: [PATCH 1/7] cxgb3 - Fix SGE page management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <465E4AA9.70706@chelsio.com>
Date:	Wed, 30 May 2007 21:10:17 -0700
From:	Divy Le Ray <divy@...lsio.com>
To:	Jeff Garzik <jeff@...zik.org>
CC:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	swise@...ngridcomputing.com
Subject: Re: [PATCH 1/7] cxgb3 - Fix SGE page management

Jeff Garzik wrote:
> divy@...lsio.com wrote:
>> From: Divy Le Ray <divy@...lsio.com>
>>
>> Streamline page management on RX.
>> Fix dma mappings.
>>
>
> NAK #2:  You should use the page_address(page) accessor rather than 
> creating a struct member in the same struct as your page, solely to 
> contain the virtual address.
Jeff,

The struct member caches the value of page_address(page) + current 
offset for optimization purposes.

Divy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/