linux-kernel - Re: Makefile question (was [RFC] LZO de/compression support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a781481a0705290427n3bad472aqf4e0b8276780b405@mail.gmail.com>
Date:	Tue, 29 May 2007 16:57:57 +0530
From:	"Satyam Sharma" <satyam.sharma@...il.com>
To:	"Michael-Luke Jones" <mlj28@....ac.uk>
Cc:	"Nitin Gupta" <nitingupta910@...il.com>,
	lkml <linux-kernel@...r.kernel.org>, linux-mm-cc@...top.org,
	linuxcompressed-devel@...ts.sourceforge.net,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Daniel Hazelton" <dhazelton@...er.net>,
	"Richard Purdie" <richard@...nedhand.com>,
	"Bret Towe" <magnade@...il.com>
Subject: Re: Makefile question (was [RFC] LZO de/compression support - take 6)

On 5/29/07, Michael-Luke Jones <mlj28@....ac.uk> wrote:
> On 29 May 2007, at 11:41, Satyam Sharma wrote:
>
> > This is syntactically correct (and wouldn't produce any build errors),
> > but it's quite ... strange, still. Why would I even want to /build/
> > the
> > compress code if all I selected was the decompress option?
>
> Apologies, you gave me the answer I was looking for (make is
> 'intelligent' enough not to build the same file twice in this
> situation...) but I think you may have missed the makefile in the
> lzo1x directory:
>
> > diff --git a/lib/lzo1x/Makefile b/lib/lzo1x/Makefile
> > new file mode 100644
> > index 0000000..7b56a4d
> > --- /dev/null
> > +++ b/lib/lzo1x/Makefile
> > @@ -0,0 +1,2 @@
> > +obj-$(CONFIG_LZO1X_COMPRESS) += lzo1x_compress.o
> > +obj-$(CONFIG_LZO1X_DECOMPRESS) += lzo1x_decompress.o

Ah, yes, I only saw the mail and didn't check lib/lzo1x/Makefile, thanks.
So effectively, we've done precisely what zlib does too ... only, in a
smarter way!

> Thus, the Kconfig options for compress/decompress won't be simply
> 'dummy' options...
>
> Given the shared private header between the compress and decompress
> code, I don't think there is any need to separate the code into two
> directories a la the zlib code.

Right, actually, zlib could be switched over to this style, in fact.
Because zlib_deflate/ and zlib_inflate/ too share a private header
zutil.h which has unfortunately been stuck into include/linux/ with a big
/* WARNING: this file should *not* be used by applications. */ comment ...

Satyam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/