linux-kernel - Re: Makefile question (was [RFC] LZO de/compression support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <37DB6EAF-8954-448D-BD29-864FEC6540CE@cam.ac.uk>
Date:	Tue, 29 May 2007 11:51:48 +0100
From:	Michael-Luke Jones <mlj28@....ac.uk>
To:	"Satyam Sharma" <satyam.sharma@...il.com>
Cc:	"Nitin Gupta" <nitingupta910@...il.com>,
	lkml <linux-kernel@...r.kernel.org>, linux-mm-cc@...top.org,
	linuxcompressed-devel@...ts.sourceforge.net,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Daniel Hazelton" <dhazelton@...er.net>,
	"Richard Purdie" <richard@...nedhand.com>,
	"Bret Towe" <magnade@...il.com>
Subject: Re: Makefile question (was [RFC] LZO de/compression support - take 6)

On 29 May 2007, at 11:41, Satyam Sharma wrote:

> This is syntactically correct (and wouldn't produce any build errors),
> but it's quite ... strange, still. Why would I even want to /build/  
> the
> compress code if all I selected was the decompress option?

Apologies, you gave me the answer I was looking for (make is  
'intelligent' enough not to build the same file twice in this  
situation...) but I think you may have missed the makefile in the  
lzo1x directory:

> diff --git a/lib/lzo1x/Makefile b/lib/lzo1x/Makefile
> new file mode 100644
> index 0000000..7b56a4d
> --- /dev/null
> +++ b/lib/lzo1x/Makefile
> @@ -0,0 +1,2 @@
> +obj-$(CONFIG_LZO1X_COMPRESS) += lzo1x_compress.o
> +obj-$(CONFIG_LZO1X_DECOMPRESS) += lzo1x_decompress.o

Thus, the Kconfig options for compress/decompress won't be simply  
'dummy' options...

Given the shared private header between the compress and decompress  
code, I don't think there is any need to separate the code into two  
directories a la the zlib code.

Sorry for noise,

Michael-Luke
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/