[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070529105135.GE29351@lst.de>
Date: Tue, 29 May 2007 12:51:35 +0200
From: Christoph Hellwig <hch@....de>
To: Geert Uytterhoeven <Geert.Uytterhoeven@...ycom.com>
Cc: Christoph Hellwig <hch@....de>, linuxppc-dev@...abs.org,
linux-kernel@...r.kernel.org
Subject: Re: [patch 7/7] ps3: FLASH ROM Storage Driver
On Tue, May 29, 2007 at 11:57:52AM +0200, Geert Uytterhoeven wrote:
> On Tue, 29 May 2007, Christoph Hellwig wrote:
> > On Fri, May 25, 2007 at 10:36:14AM +0200, Geert.Uytterhoeven@...ycom.com wrote:
> > > Add a FLASH ROM Storage Driver for the PS3:
> > > - Implemented as a misc character device driver
> > > - Uses a fixed 256 KiB buffer allocated from boot memory as the hypervisor
> > > requires the writing of aligned 256 KiB blocks
> >
> > Looks good, but please either make the driver aware of multiple devices
> > even if they can't happen currently, or alternatively error out in
> > ->probe if of some reason it's called for a second device.
>
> ps3flash_probe() does return -EBUSY when called for a second device.
You're right, I missed that bit.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists