linux-kernel - Re: [PATCH -mm] 1/2: MMCONFIG: validate against ACPI motherboard resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <465D38CA.5050805@gmail.com>
Date:	Wed, 30 May 2007 09:41:46 +0100
From:	Matt Keenan <tank.en.mate@...il.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
CC:	Robert Hancock <hancockr@...w.ca>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>
Subject: Re: [PATCH -mm] 1/2: MMCONFIG: validate against ACPI motherboard
 resources

Linus Torvalds wrote:
> On Tue, 29 May 2007, Robert Hancock wrote:
>   
>> This path adds validation of the MMCONFIG table against the ACPI reserved
>> motherboard resources.
>>     
>
> Please fix the formatting of your code.
>
>   
[snip snip]
> Same goes for this thing:
>
> +                       if((pci_probe & PCI_PROBE_CONF1) &&
> +                          e820_all_mapped(cfg->address,
> +                                          cfg->address + size - 1,
> +                                          E820_RESERVED))
> +                               printk(KERN_NOTICE "PCI: MCFG area at %Lx reserved in E820\n",
> +                                       cfg->address);
> +                       else
> +                               goto reject;
>
> there really is *not* a highly coveted prize for having the most different 
> indentation in the fewest possible lines of code!
>
>   

That looks like standard lisp style indenting (yes I realise that C != 
lisp).  At a guess I would say that code was written in emacs (which can 
be fixed by the necessary changes in your ~/.emacs). Grand parent post 
should check out these resources, they may help...

http://www.bloomington.in.us/~brutt/emacs-c-dev.html
http://lug.umbc.edu/tutorials/adv-emacs.html

or if you are really gung ho the CC-mode documentation

http://www.chemie.fu-berlin.de/chemnet/use/info/cc-mode/cc-mode_6.html

Matt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/