linux-kernel - Re: [PATCH -mm] 1/2: MMCONFIG: validate against ACPI motherboard resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <465D8BA1.1080800@shaw.ca>
Date:	Wed, 30 May 2007 08:35:13 -0600
From:	Robert Hancock <hancockr@...w.ca>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>
Subject: Re: [PATCH -mm] 1/2: MMCONFIG: validate against ACPI motherboard
 resources

Linus Torvalds wrote:
> On Tue, 29 May 2007, Robert Hancock wrote:
>> This path adds validation of the MMCONFIG table against the ACPI reserved
>> motherboard resources.
> 
> Please fix the formatting of your code.
> 
> "for" and "if" are not functions, and they have a space before the 
> parenthesis.
> 
> And pretty much every single conditional in this patch is spread out over 
> two or more lines and has at least three different indentations. There's 
> something wrong here. Code can't look this bad and still be fine. Some of 
> this looks like random whitespace noise:
> 
> +               if(is_acpi_reserved(cfg->address,
> +                                   cfg->address + size - 1))
> +                       printk(KERN_NOTICE "PCI: MCFG area at %Lx reserved "
> +                               "in ACPI motherboard resources\n",
> +                               cfg->address);
> +               else {
> 
> That's just horrid. Please try to make the code _look_ nicer.

I'll try and fix up the formatting and repost this patch. I suspect some
of the issues are from the added code clashing with the way the existing
code was formatted.

-- 
Robert Hancock      Saskatoon, SK, Canada
To email, remove "nospam" from hancockr@...pamshaw.ca
Home Page: http://www.roberthancock.com/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/