linux-kernel - Re: + fix-soft-lockup-when-removing-netconsole-module.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070530210137.GA225@tv-sign.ru>
Date:	Thu, 31 May 2007 01:01:37 +0400
From:	Oleg Nesterov <oleg@...sign.ru>
To:	Jason Wessel <jason.wessel@...driver.com>
Cc:	Stephen Hemminger <shemminger@...l.org>,
	"David S. Miller" <davem@...emloft.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: + fix-soft-lockup-when-removing-netconsole-module.patch added to -mm tree

Jason Wessel wrote:
>
> The netpoll_cleanup handler can hang the kernel if there is no work in the
> work queue because a call to cancel_rearming_delayed_work() with no work
> goes into an infinite loop.

This should not be true any longer, cancel_rearming_delayed_work() should work
correctly in any case.

Could you please clarify?

> @@ -771,30 +771,32 @@ void netpoll_cleanup(struct netpoll *np)
>
> [...snip...]
>
> +		if (atomic_dec_and_test(&npinfo->refcnt)) {
> +			skb_queue_purge(&npinfo->arp_tx);
> +			skb_queue_purge(&npinfo->txq);
> +			if (delayed_work_pending(&npinfo->tx_work)) {
>  				cancel_rearming_delayed_work(&npinfo->tx_work);
>  				flush_scheduled_work();

But this "if (delayed_work_pending())" is racy anyway?

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/