linux-kernel - Re: [PATCH] add a trivial patch style checker II

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070531195917.GC31153@redhat.com>
Date:	Thu, 31 May 2007 15:59:17 -0400
From:	Dave Jones <davej@...hat.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Andy Whitcroft <apw@...dowen.org>, Andrew Morton <akpm@...l.org>,
	Randy Dunlap <rdunlap@...otime.net>,
	Joel Schopp <jschopp@...tin.ibm.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] add a trivial patch style checker II

On Thu, May 31, 2007 at 02:07:53PM +0200, Andi Kleen wrote:
 > > Yeah, that is a very sensible idea.
 > > 
 > > > Possible further checks that might make sense:
 > > > - panic() anywhere in drivers/* 
 > > > - externs in .c files without asmlinkage
 > > > - general checking that everything in a fully visible {} block is the right 
 > > > indentation
 > > > 
 > 
 > Here are some more warnings I would like to see:
 > 
 > - Warning for any spinlock/mutex definition that doesn't have a comment
 > nearby (all locks ought to be documented) 

Also barriers. (Probably even moreso).

	Dave

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/