linux-kernel - Re: [PATCH 2.6.21 3/3] x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m1y7j3zew8.fsf@ebiederm.dsl.xmission.com>
Date:	Fri, 01 Jun 2007 12:52:07 -0600
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Chandramouli Narayanan <mouli@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org, ak@...e.de, akpm@...ux-foundation.org
Subject: Re: [PATCH 2.6.21 3/3] x86_64: EFI64 support

Chandramouli Narayanan <mouli@...ux.intel.com> writes:

> +
> +static int __init efifb_init(void)
> +{
> +	int ret;
> +
> +	if (!efi_enabled)
> +		return -ENODEV;
> +

Please remove this efi_enabled check it appears  redundant with
the check immediately below.

> +	if (screen_info.orig_video_isVGA != VIDEO_TYPE_EFI)
> +		return -ENODEV;
> +
> +
> +	ret = platform_driver_register(&efifb_driver);
> +
> +	if (!ret) {
> +		ret = platform_device_register(&efifb_device);
> +		if (ret)
> +			platform_driver_unregister(&efifb_driver);
> +	}
> +	return ret;
> +}
> +module_init(efifb_init);

Eric

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/