linux-kernel - Re: [patch 1/1] document Acked-by:

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 02 Jun 2007 02:56:30 +0200
From:	Krzysztof Halasa <khc@...waw.pl>
To:	"John Anthony Kazos Jr." <jakj@...-k-j.com>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Scott Preece <sepreece@...il.com>, Valdis.Kletnieks@...edu,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [patch 1/1] document Acked-by:

"John Anthony Kazos Jr." <jakj@...-k-j.com> writes:

> "Acked-by:" does not mean "I like this" but rather "I approve of this".

I'd say it means "I acknowledge it". If you want to express
approval, why not use some sort of "Approved-by"?

> If I put "Acked-by: John..." on a patch of any kind, even trivial, it 
> would look incredibly stupid, because I'm just some guy messing around 
> with the kernel. A tactful response to me doing that from any actual 
> kernel bigwig would be, "I appreciate your enthusiasm, but you are not 
> part of the kernel patch flow." Similarly, a tactful response to me 
> NACKing a patch would be, "I appreciate your concern, but you are in no 
> position to remove a patch from the stream. Your comments will be 
> considered and implemented or countered by an actual maintainer."
>
> This is appropriate.

You seem to know these things very well.
-- 
Krzysztof Halasa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/