linux-kernel - Re: [patch 1/1] document Acked-by:

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8127.1180748167@turing-police.cc.vt.edu>
Date:	Fri, 01 Jun 2007 21:36:07 -0400
From:	Valdis.Kletnieks@...edu
To:	Krzysztof Halasa <khc@...waw.pl>
Cc:	Scott Preece <sepreece@...il.com>,
	"John Anthony Kazos Jr." <jakj@...-k-j.com>,
	"H. Peter Anvin" <hpa@...or.com>, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [patch 1/1] document Acked-by:

On Sat, 02 Jun 2007 00:10:46 +0200, Krzysztof Halasa said:
> "Scott Preece" <sepreece@...il.com> writes:
> 
> > This is a question worth answering - is it rude to ack/nak a patch if
> > you're not a maintainer or otherwise known-to-be-trusted, or is it OK
> > for anyone to express an opinion? Andrew's patch text seems to imply
> > that it's generally OK.
> 
> Every pair of eyes (or a single one) looking at the patch in question
> is a good thing. I can't imagine why would one want to look at the
> code if he/she can't ack or nak or otherwise comment it.

I'd be the *first* to admit that my kernel-foo isn't perfect, and sometimes I'm
right and sometimes I'm wrong when I review somebody else's code.  I certainly
*hope* that nobody's taking my review as anything more authoritative than "an
actual maintainer might want to look at this".

On the other hand, we don't need a Foo-By: tag for "or otherwise comment".

Phrased differently, if I haven't stuck a "Signed-off-by:" or "Tested-By:"
on it, I'm by default only commenting.  The code submitter can decide I'm right
and fix and resubmit, the maintainer can decide I'm right and toss a NAK. Or
they can both decide I'm full of it and hit the Delete key..

Content of type "application/pgp-signature" skipped