linux-kernel - Re: libata & no PCI: dma_[un]map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070605155219.GB29508@flint.arm.linux.org.uk>
Date:	Tue, 5 Jun 2007 16:52:19 +0100
From:	Russell King <rmk+lkml@....linux.org.uk>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Jeff Garzik <jeff@...zik.org>,
	Christoph Hellwig <hch@...radead.org>,
	David Miller <davem@...emloft.net>, mroos@...ux.ee,
	linux-kernel@...r.kernel.org
Subject: Re: libata & no PCI: dma_[un]map_single undefined

On Tue, Jun 05, 2007 at 04:50:56PM +0100, Alan Cox wrote:
> > If you don't have DMA capabilities, does libata still need ->pad and
> > ->pad_dma set?
> 
> It shouldn't - nor the prd. You don't need to use the default
> ata_port_start in this case. I've just added ata_sff_port_start to my
> tree which figures out which to allocate for SFF devices.

I had already sorted out the PRD, but I couldn't convince myself that
the pad stuff wasn't used, so for pata_icside I had:

static int pata_icside_port_start(struct ata_port *ap)
{
        /* No PRD to alloc */
        return ata_pad_alloc(ap, ap->dev);
}

Therefore, I can just arrange for this to do nothing and just return
zero.  A similar fix for pata_platform should probably also be in order
as well.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/