linux-kernel - Re: [PATCH] never called printk statement in ide-taskfile.c::wait_drive_not

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4665988A.5060902@redhat.com>
Date:	Tue, 05 Jun 2007 13:08:26 -0400
From:	Chuck Ebbert <cebbert@...hat.com>
To:	Masatake YAMATO <jet@...e.org>
CC:	Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@...a.pw.edu.pl>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] never called printk statement in ide-taskfile.c::wait_drive_not_busy

On 06/04/2007 10:21 PM, Masatake YAMATO wrote:
> diff --git a/drivers/ide/ide-taskfile.c b/drivers/ide/ide-taskfile.c
> index 30175c7..5e05311 100644
> --- a/drivers/ide/ide-taskfile.c
> +++ b/drivers/ide/ide-taskfile.c
> @@ -249,7 +249,7 @@ static u8 wait_drive_not_busy(ide_drive_t *drive)
>  	while (((stat = hwif->INB(IDE_STATUS_REG)) & BUSY_STAT) && retries--)
>  		udelay(10);
>  
> -	if (!retries)
> +	if (retries < 0)

	if (stat & BUSY_STAT)

>  		printk(KERN_ERR "%s: drive still BUSY!\n", drive->name);
>  
>  	return stat;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/