linux-kernel - Re: [RFC] tablet buttons driver for fujitsu siemens laptops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Jun 2007 10:45:42 +0200
From:	Robert Gerlach <khnz@...z.de>
To:	linux-kernel@...r.kernel.org
Subject: Re: [RFC] tablet buttons driver for fujitsu siemens laptops

On Saturday 02 June 2007 03:30:54 Stephen Hemminger wrote:
> On Sat, 2 Jun 2007 02:59:33 +0200
> > #ifdef DEBUG
> > #  define debug(m, a...)	printk( KERN_DEBUG   MODULENAME ": " m "\n",
> > ##a) #else
> > #  define debug(m, a...)	do {} while(0)
> > #endif
> >
> > #define info(m, a...)	printk( KERN_INFO    MODULENAME ": " m "\n", ##a)
> > #define warn(m, a...)	printk( KERN_WARNING MODULENAME ": " m "\n", ##a)
> > #define error(m, a...)	printk( KERN_ERR     MODULENAME ": " m "\n", ##a)
>
> Please don't reinvent
> 	pr_debug
> 	pr_info

Changed.

> 	pr_warn,...

There is no pr_warn. Is it ok to define it like pr_err in spider_net.c or is 
there a better way?


Many thanks,
Robert

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/