linux-kernel - [PATCH] spi_mpc83xx.c underclocking hotfix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 6 Jun 2007 19:34:03 +0200
From:	Clifford Wolf <clifford@...fford.at>
To:	galak@...nel.crashing.org
Cc:	lkml <linux-kernel@...r.kernel.org>
Subject: [PATCH] spi_mpc83xx.c underclocking hotfix

Hi kumar (spi_mpc83xx maintainer), Hi list,

the MPC83xx SPI controller clock divider can divide the system clock by not
more then 1024. The spi_mpc83xx driver does not check this and silently
writes garbage to the SPI controller registers when asked to run at lower
frequencies. I've tried to run the SPI on a 266MHz MPC8349E with 100kHz for
debugging a bus problem and suddenly was confronted with a 2nd problem to
debug..  ;-)

The attached patch adds an additional check which avoids writing garbage to
the SPI controller registers and warn the user about it. This might help
others to avoid simmilar problems.

yours,
 - clifford

-- 
Hardware /nm./: the part of the computer that you can kick.

View attachment "spi_mpc83xx_hotfix.patch" of type "text/plain" (692 bytes)