linux-kernel - Re: [-mm patch] kernel/sched{,

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 Jun 2007 23:54:41 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Adrian Bunk <bunk@...sta.de>
Cc:	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org
Subject: Re: [-mm patch] kernel/sched{,_fair}.c: make code static

On Tue, 5 Jun 2007 23:50:56 +0200 Adrian Bunk <bunk@...sta.de> wrote:

> This patch makes some needlessly global code static.
> 
> Signed-off-by: Adrian Bunk <bunk@...sta.de>
> 
> ---
> 
> BTW: Please don't #include C files in sched.c

Yeah.

> -long div64_s(s64 divident, unsigned long divisor)
> +static long div64_s(s64 divident, unsigned long divisor)

"divident" does appear to be a word, but I suspect "dividend" was intended.

Why is this function lurking in the CPU scheduler rather than in
lib/somewhere.c?

Doesn't an unsigned divide give the same result as a signed one?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/