linux-kernel - Re: [PATCH] intel-rng: Undo mess made by an 80 column extremist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200706072232.37051.s0348365@sms.ed.ac.uk>
Date:	Thu, 7 Jun 2007 22:32:36 +0100
From:	Alistair John Strachan <s0348365@....ed.ac.uk>
To:	Krzysztof Halasa <khc@...waw.pl>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>, akpm@...l.org,
	linux-kernel@...r.kernel.org, jeff@...zik.org
Subject: Re: [PATCH] intel-rng: Undo mess made by an 80 column extremist

On Thursday 07 June 2007 22:17:18 Krzysztof Halasa wrote:
> Alan Cox <alan@...rguk.ukuu.org.uk> writes:
> > The intel-rng printed a nice well formatted message when the port was
> > disabled. Someone then came along and blindly trashed it by screwing up a
> > trim down to 80 columns.
>
> Perhaps we should drop that 80-column style and use some 120+?
> X or no X, almost all people now have more lines and columns on their
> displays than MDA 20 years ago.
>
> 132 to match text VGA perhaps?
> 80 can be left for the actual _output_, I mean number of chars printed
> by kernel code.

I personally buy the argument that 80 cols helps remind people that they've 
used too many indentation depths and should redesign their code. I think it's 
a good thing to stick to where possible, even if just from a design 
perspective.

There are some cases such as the one Alan has pointed out here where being 
strictly 80 cols seems more destructive than useful, but those are the 
exception, not the rule (IMO).

-- 
Cheers,
Alistair.

Final year Computer Science undergraduate.
1F2 55 South Clerk Street, Edinburgh, UK.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/