linux-kernel - Re: [PATCH] intel-rng: Undo mess made by an 80 column extremist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 08 Jun 2007 00:06:05 +0200
From:	Krzysztof Halasa <khc@...waw.pl>
To:	Alistair John Strachan <s0348365@....ed.ac.uk>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>, akpm@...l.org,
	linux-kernel@...r.kernel.org, jeff@...zik.org
Subject: Re: [PATCH] intel-rng: Undo mess made by an 80 column extremist

Alistair John Strachan <s0348365@....ed.ac.uk> writes:

> I personally buy the argument that 80 cols helps remind people that they've 
> used too many indentation depths and should redesign their code.
> I think it's 
> a good thing to stick to where possible, even if just from a design 
> perspective.

How many is too many? A function with 2 "if" means 3 tabs = 24 characters
for just indentation. Add a printk(KERN_DEBUG "\n"); and you can print
ca. 30 characters without having to break the string. This is crazy.

> There are some cases such as the one Alan has pointed out here where being 
> strictly 80 cols seems more destructive than useful, but those are the 
> exception, not the rule (IMO).

Well... I was forced to split functions making the code less readable
and more complicated just to avoid these 80-columns. A short function
with more indent levels may be way more readable than a redesigned one
with this requirement in mind.

I'd just state the code has to be readable and laid out with some sanity
but 80 columns give us nothing WRT this.

We already review new code and spot such problems (and smaller ones)
without using the 80-cols rule.
-- 
Krzysztof Halasa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/