linux-kernel - Re: [SERIAL] Don't optimise away baud rate changes when BOTHER is used (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070608124206.49628160@the-village.bc.nu>
Date:	Fri, 8 Jun 2007 12:42:06 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	David Woodhouse <dwmw2@...radead.org>
Cc:	akpm@...l.org, linux-kernel@...r.kernel.org, paulus@...ba.org
Subject: Re: [SERIAL] Don't optimise away baud rate changes when BOTHER is
 used (v2)

On Fri, 08 Jun 2007 12:14:49 +0100
David Woodhouse <dwmw2@...radead.org> wrote:

> The uart_set_termios() function will bail out early without bothering to
> touch the hardware, if it decides that nothing "relevant" has changed.
> Unfortunately, its idea of "relevant" doesn't include c_[io]speed. So if
> the baud rate bits are BOTHER and you just change the speed, the change
> gets optimised away.
> 
> This patch makes it ignore the old Bfoo bits in c_cflag and just check
> whether c_ispeed and c_ospeed have changed. Those integers are always
> set appropriately for us by set_termios().
> 
> This version of the patch lacks the debugging printk which I
> accidentally left in the previous one.
> 
> Signed-off-by: David Woodhouse <dwmw2@...radead.org>

Acked-by: Alan Cox <alan@...hat.com>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/