linux-kernel - Re: [SERIAL] Don't optimise away baud rate changes when BOTHER is used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070608124853.5fdfaee2@the-village.bc.nu>
Date:	Fri, 8 Jun 2007 12:48:53 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	David Woodhouse <dwmw2@...radead.org>
Cc:	akpm@...l.org, linux-kernel@...r.kernel.org, paulus@...ba.org
Subject: Re: [SERIAL] Don't optimise away baud rate changes when BOTHER is
 used

> It works fine. The only problem is that if I set a _standard_ baud rate
> with BOTHER and then read it back with something that doesn't grok
> BOTHER, I get it back just as I set it.

That seemed to me to be the right thing to do.

> It might be better if it was returning B38400, rather than BOTHER.
> Should we be using tty_termios_encode_baud_rate() for TCGETS()?

You can't really do that as you get weird behaviour then when people do

	tcgetattr
		|= BOTHER;
		speed = 19200;
	tcsetattr

later in the same app

	tcgetattr
		speed = 38400
	tcsetattr

knowing that they set BOTHER already.

I guess you could add both ioctl sets anyway but the plan longer term is
for glibc tcsetattr/getattr to do the right thing with the new ioctls in
all cases, as the glibc interface already provides speed fields.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/