linux-kernel - [PATCH] Include <asm/termbits.h> from <linux/tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0706080925020.24228@localhost.localdomain>
Date:	Fri, 8 Jun 2007 09:29:12 -0400 (EDT)
From:	"Robert P. J. Day" <rpjday@...dspring.com>
To:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
cc:	Andrew Morton <akpm@...l.org>
Subject: [PATCH] Include <asm/termbits.h> from <linux/tty_driver.h>.


The header file <linux/tty_driver.h> should include <asm/termbits.h>
to pick up the definition of "struct ktermios"; otherwise, you run the
risk of seeing:

include/linux/tty_driver.h:142: warning: 'struct ktermios' \
	declared inside parameter list
include/linux/tty_driver.h:142: warning: its scope is only \
	this definition or declaration, which is probably not what you want

Signed-off-by: Robert P. J. Day <rpjday@...dspring.com>

---

  i'm *guessing* this is the solution to the above issue.


diff --git a/include/linux/tty_driver.h b/include/linux/tty_driver.h
index 85c95cd..b687174 100644
--- a/include/linux/tty_driver.h
+++ b/include/linux/tty_driver.h
@@ -123,6 +123,7 @@
 #include <linux/fs.h>
 #include <linux/list.h>
 #include <linux/cdev.h>
+#include <asm/termbits.h>

 struct tty_struct;


-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/