linux-kernel - Re: [i2c] i2c module aliases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 8 Jun 2007 15:35:16 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	Greg KH <greg@...ah.com>, Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	i2c@...sensors.org,
	Linux Kernel Development <linux-kernel@...r.kernel.org>,
	David Brownell <david-b@...bell.net>
Subject: Re: [i2c] i2c module aliases

On Thu, 7 Jun 2007 09:02:14 -0700, Greg KH wrote:
> On Thu, Jun 07, 2007 at 05:53:42PM +0200, Jean Delvare wrote:
> > Looks correct. However I am curious what this "i2c->id" is supposed to
> > represent, given that I2C devices do not have any form of ID as PCI or
> > USB devices have. No driver uses "MODULE_DEVICE_TABLE(i2c, ...)"
> > probably just because it doesn't make sense. So, rather than fixing
> > this, shouldn't we simply wipe out struct i2c_device_id? Greg, David?
> 
> If no one is using it, then yes, it should be removed.
> 
> Sorry, I added it a while ago thinking it was going to be used (I had
> test patches using it in my tree, but they never worked out in the end.)

OK. Geert, care to submit a new patch removing struct i2c_device_id
altogether?

Thanks,
-- 
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/