linux-kernel - Re: [patch 7/8] fdmap v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0706081533430.5795@alien.or.mcafeemobile.com>
Date:	Fri, 8 Jun 2007 15:38:53 -0700 (PDT)
From:	Davide Libenzi <davidel@...ilserver.org>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
cc:	Ulrich Drepper <drepper@...hat.com>, Theodore Tso <tytso@....edu>,
	Eric Dumazet <dada1@...mosbay.com>,
	Kyle Moffett <mrmacman_g4@....com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: [patch 7/8] fdmap v2 - implement sys_socket2

On Fri, 8 Jun 2007, Alan Cox wrote:

> > > > It does not work. What if the main application, library A and library B 
> > > > wants to implement their own allocation strategy?
> > > 
> > > Its called "discipline". I would suggest that libc contains a default
> > > allocator. You might also want to assign library and application ranges
> > > for clarity.
> > 
> > That is really nice solution. Each library has to have each own allocator. 
> 
> Are you being deliberately stupid ?
> 
> I suggested *libc* contains a default allocator

"You might also want to assign library and application ranges for clarity."

So let's see. We have the legacy one (1st fdtable), the non-legacy app one 
(2nd fdtable) and one for the library (3rd fdtable). And which library? 
Each one his own (4th, 5th ... fdtable)? ...



> > replicated all around the code that access directly the fdtables. I did 
> > the fdmap consolidation patch, and I can tell you there are quite a few 
> > places that access fdtables directly.
> 
> This is true, but if you are worried about complexity we get back to the
> original posix allocator which packs them in tight and produces a most
> excellent spread in the general case (whacko apps like bash aside)

... complexity does not come from the allocator, but from the fact that 
direct access to the fdtable is done all over the kernel. Code that 
assumes there's only *one* fdtable.



- Davide


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/