linux-kernel - Re: [patch-mm 06/23] clockevents: Fix resume logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200706101258.48721.rjw@sisk.pl>
Date:	Sun, 10 Jun 2007 12:58:47 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	LKML <linux-kernel@...r.kernel.org>, Andrew Morton <akpm@...l.org>,
	Ingo Molnar <mingo@...e.hu>, Andi Kleen <ak@...e.de>,
	Arjan van de Ven <arjan@...radead.org>,
	Venkatesh Pallipadi <venkatesh.pallipadi@...el.com>,
	Chris Wright <chrisw@...s-sol.org>
Subject: Re: [patch-mm 06/23] clockevents: Fix resume logic

On Sunday, 10 June 2007 12:30, Thomas Gleixner wrote:
> On Sun, 2007-06-10 at 12:19 +0200, Rafael J. Wysocki wrote:
> > > -/*
> > > - * Suspend/resume part
> > > - */
> > > -
> > > -#ifdef CONFIG_PM
> > > -
> > > -static int hpet_suspend(struct sys_device *sys_device, pm_message_t state)
> > > -{
> > > -	unsigned long cfg = hpet_readl(HPET_CFG);
> > > -
> > > -	cfg &= ~(HPET_CFG_ENABLE|HPET_CFG_LEGACY);
> > > -	hpet_writel(cfg, HPET_CFG);
> > > -
> > > -	return 0;
> > > -}
> > 
> > Hmm, I haven't found anything to replace the above in the patch.  Is that
> > intentional, or is it there, but I haven't noticed?
> 
> > > +	case CLOCK_EVT_MODE_RESUME:
> > > +		hpet_enable_int();
> > > +		break;

This is the resume part, or at least it seems so, but the above one is a
suspend callback.  If I understand it correctly, this one replaces
hpet_resume(), but is it sufficient for the suspend part too?

Greetings,
Rafael


-- 
"Premature optimization is the root of all evil." - Donald Knuth
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/