linux-kernel - Re: [PATCH] PCI: also read revision ID for sparc64, ppc, read class at the same time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <59594cddc7b5eb6e355fd01efef8ebcc@kernel.crashing.org>
Date:	Sun, 10 Jun 2007 14:17:48 +0200
From:	Segher Boessenkool <segher@...nel.crashing.org>
To:	michael@...erman.id.au
Cc:	Paul Mackerras <paulus@...ba.org>, linux-kernel@...r.kernel.org,
	linux-pci@...ey.karlin.mff.cuni.cz,
	Auke Kok <auke-jan.h.kok@...el.com>, gregkh@...e.de,
	davem@...emloft.net, grundler@...isc-linux.org
Subject: Re: [PATCH] PCI: also read revision ID for sparc64, ppc, read class at the same time

>> +	dev->revision = get_int_prop(node, "revision-id", 0);
>
> It's not clear to me in the spec if nodes are required to have the
> "revision-id" property.

It is required for every PCI node.

> I guess 0 is a safe default though.

As good as any -- that is, no default is save.  0 should
be "good enough" here I guess.


Segher

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/