linux-kernel - fix oops on cat /dev/snapshot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070611121716.GA1904@elf.ucw.cz>
Date:	Mon, 11 Jun 2007 14:17:16 +0200
From:	Pavel Machek <pavel@....cz>
To:	B.Steinbrink@....de, "Rafael J. Wysocki" <rjw@...k.pl>,
	Andrew Morton <akpm@...l.org>,
	kernel list <linux-kernel@...r.kernel.org>
Subject: fix oops on cat /dev/snapshot

What /dev/snapshot is simply cat-ed -- without ioctls used in normal
operation -- it oopses. This one should fix it.

Signed-off-by: Pavel Machek <pavel@...e.cz>

--- clean-mm/kernel/power/user.c	2007-06-09 16:18:12.000000000 +0200
+++ linux-mm/kernel/power/user.c	2007-06-11 14:06:19.000000000 +0200
@@ -99,6 +99,8 @@
 	ssize_t res;
 
 	data = filp->private_data;
+	if (!data->ready)
+		return -EINVAL;
 	res = snapshot_read_next(&data->handle, count);
 	if (res > 0) {
 		if (copy_to_user(buf, data_of(data->handle), res))

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/