linux-kernel - Re: fix oops on cat /dev/snapshot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Jun 2007 16:36:42 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Pavel Machek <pavel@....cz>
Cc:	B.Steinbrink@....de, Andrew Morton <akpm@...l.org>,
	kernel list <linux-kernel@...r.kernel.org>
Subject: Re: fix oops on cat /dev/snapshot

On Monday, 11 June 2007 14:17, Pavel Machek wrote:
> What /dev/snapshot is simply cat-ed -- without ioctls used in normal
> operation -- it oopses. This one should fix it.
> 
> Signed-off-by: Pavel Machek <pavel@...e.cz>
> 
> --- clean-mm/kernel/power/user.c	2007-06-09 16:18:12.000000000 +0200
> +++ linux-mm/kernel/power/user.c	2007-06-11 14:06:19.000000000 +0200
> @@ -99,6 +99,8 @@
>  	ssize_t res;
>  
>  	data = filp->private_data;
> +	if (!data->ready)
> +		return -EINVAL;

I'd like to use -ENODATA here.

>  	res = snapshot_read_next(&data->handle, count);
>  	if (res > 0) {
>  		if (copy_to_user(buf, data_of(data->handle), res))
> 

I have a patch for that and I'm going to post it in a while if you don't
mind.

I've already posted it once, here: http://lkml.org/lkml/2007/6/10/146

Greetings,
Rafael


-- 
"Premature optimization is the root of all evil." - Donald Knuth
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/