[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20070611143219.GA1759@elf.ucw.cz>
Date: Mon, 11 Jun 2007 16:32:19 +0200
From: Pavel Machek <pavel@....cz>
To: "Rafael J. Wysocki" <rjw@...k.pl>
Cc: B.Steinbrink@....de, Andrew Morton <akpm@...l.org>,
kernel list <linux-kernel@...r.kernel.org>
Subject: Re: fix oops on cat /dev/snapshot
Hi!
> > What /dev/snapshot is simply cat-ed -- without ioctls used in normal
> > operation -- it oopses. This one should fix it.
> >
> > Signed-off-by: Pavel Machek <pavel@...e.cz>
> >
> > --- clean-mm/kernel/power/user.c 2007-06-09 16:18:12.000000000 +0200
> > +++ linux-mm/kernel/power/user.c 2007-06-11 14:06:19.000000000 +0200
> > @@ -99,6 +99,8 @@
> > ssize_t res;
> >
> > data = filp->private_data;
> > + if (!data->ready)
> > + return -EINVAL;
>
> I'd like to use -ENODATA here.
>
> > res = snapshot_read_next(&data->handle, count);
> > if (res > 0) {
> > if (copy_to_user(buf, data_of(data->handle), res))
> >
>
> I have a patch for that and I'm going to post it in a while if you don't
> mind.
>
> I've already posted it once, here: http://lkml.org/lkml/2007/6/10/146
Aha, go ahead, I did not notice that mail.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists