linux-kernel - Re: [PATCH] x86: fix improper .init-type section references

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070613043526.GA20088@uranus.ravnborg.org>
Date:	Wed, 13 Jun 2007 06:35:26 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Satyam Sharma <satyam.sharma@...il.com>
Cc:	Jan Beulich <jbeulich@...ell.com>,
	Venkatesh Pallipadi <venkatesh.pallipadi@...el.com>,
	Andi Kleen <ak@...e.de>, linux-kernel@...r.kernel.org,
	patches@...-64.org
Subject: Re: [PATCH] x86: fix improper .init-type section references

> 
> Yup, we were only discussing possibility that modpost not complain
> about .init -> .exit references that will never go oops (because the arch
> guarantees that).

And there are no good reasosns why the rules should be different for i386
and powerpc.
This type of special casing is always bad.
Think about it a little.
Someone writes a generic driver and test it on i386 - OK.
But for powerpc it result in a build failure. It would be so much better
to warn about this situation early.

We had this exact issue in loop.c recently - so it is not a made up example.
[I recall it was ia64 that had a build failure but the example still holds ture]

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/