[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <466FB20D.76E4.0078.0@novell.com>
Date: Wed, 13 Jun 2007 08:59:57 +0200
From: "Jan Beulich" <jbeulich@...ell.com>
To: "Satyam Sharma" <satyam.sharma@...il.com>,
"Sam Ravnborg" <sam@...nborg.org>
Cc: "Venkatesh Pallipadi" <venkatesh.pallipadi@...el.com>,
"Andi Kleen" <ak@...e.de>, <linux-kernel@...r.kernel.org>,
<patches@...-64.org>
Subject: Re: [PATCH] x86: fix improper .init-type section references
>>> Sam Ravnborg <sam@...nborg.org> 13.06.07 06:35 >>>
>>
>> Yup, we were only discussing possibility that modpost not complain
>> about .init -> .exit references that will never go oops (because the arch
>> guarantees that).
>
>And there are no good reasosns why the rules should be different for i386
>and powerpc.
>This type of special casing is always bad.
>Think about it a little.
>Someone writes a generic driver and test it on i386 - OK.
>But for powerpc it result in a build failure. It would be so much better
>to warn about this situation early.
And I didn't mean to special case it - I meant to suggest changing the semantics
generally, which is why I gave the example of calling cleanup code (__exit)
from error paths in startup code (__init).
Jan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists